Reorder validation_history parameters to be more idiomatic#1959
Merged
Fokko merged 1 commit intoapache:mainfrom May 2, 2025
Merged
Reorder validation_history parameters to be more idiomatic#1959Fokko merged 1 commit intoapache:mainfrom
validation_history parameters to be more idiomatic#1959Fokko merged 1 commit intoapache:mainfrom
Conversation
gabeiglio
pushed a commit
to Netflix/iceberg-python
that referenced
this pull request
Aug 13, 2025
…1959) <!-- Thanks for opening a pull request! --> <!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> # Rationale for this change Nit: the current order (`to_snapshot` before `from_snapshot`) is unexpected and [error-prone](https://github.com/apache/iceberg-python/pull/1938/files#r2070985497). This PR proposes to reorder these parameters in `validation_history` and `ancestors_between` so that it is more idiomatic. # Are these changes tested? Yes, through integration and unit tests # Are there any user-facing changes? Yes, but these functions were just introduced (no releases were made yet with these functions) <!-- In the case of user-facing changes, please add the changelog label. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Nit: the current order (
to_snapshotbeforefrom_snapshot) is unexpected and error-prone.This PR proposes to reorder these parameters in
validation_historyandancestors_betweenso that it is more idiomatic.Are these changes tested?
Yes, through integration and unit tests
Are there any user-facing changes?
Yes, but these functions were just introduced (no releases were made yet with these functions)